KEP-981keps/sig-apps/981-poddisruptionbudget-for-custom-resources

pdb-support-for-custom-resources-with-scale-subresource

implementedstablesig-appslatest v1.15

KEP on GitHub kep.yaml Ask about this KEP

Pod Disruption Budget (PDB) is a Kubernetes API that limits the number of pods of a collection that are down simultaneously from voluntary disruptions. PDBs allows a user to specify the allowed disruption through either min available or max unavailable number of pods. In order to support PDBs where max number of unavailable pods is set, the PDB controller needs to be able to look up the desired number of replicas. It does this by looking at the controller(s) (as specified by the owner ref) for the pods covered by the PDB. Currently only four of the basic workload controllers are supported for PDBs, namely Deployment, StatefulSet, ReplicaSet and ReplicationController. The scale subresource allows any resource to specify its desired number of replicas and a generic way to look up this information. This document lays out a plan to use the scale subresource to allow setting PDBs for any resource implementing the scale subresource.

Facts

Authors: @mortent
Approvers: @kow3ns @janetkuo
Reviewers: @kow3ns @janetkuo
PRR approvers: none
Tracking issue: #981(opens GitHub in a new tab) closedcompletedclosed 2019-07-30 14:38 UTCsig/appsstage/stable
Milestones: none
Participating SIGs: sig-scheduling sig-autoscaling
Feature gates: none
Created / last updated: 2019-04-12 / 2019-04-12

Who decided each state, with the evidence.
Decided	Decision	Deciders	Evidence
2020-12-17 19:39 UTC	status_transition KEP-981 status set to implementable in PR #2196, approved by johnbelamaric; merged by automation (k8s-ci-robot) on 2020-12-17.	@wojtek-t author @johnbelamaric approve_command @johnbelamaric lgtm @k8s-ci-robot merger	Commit kubernetes/enhancements@5f128c7d78b27f56569f0e8a63178c746323497f(opens GitHub in a new tab) StatusChange status ∅ → implementable (2020-12-17)(opens GitHub in a new tab) PullRequest kubernetes/enhancements#2196 Migrate some apps KEPs to new template(opens GitHub in a new tab) Comment kubernetes/enhancements/issues/comments/747653854(opens GitHub in a new tab)
2021-05-05 19:23 UTC	stage_graduation KEP-981 graduated to stable in PR #2672, approved by johnbelamaric; merged by automation (k8s-ci-robot) on 2021-05-05.	@ehashman author @johnbelamaric approve_command @johnbelamaric lgtm @k8s-ci-robot merger	Commit kubernetes/enhancements@f343d8b94f8b83e8496ae42313f1290c1767bba6(opens GitHub in a new tab) StatusChange stage ∅ → stable (2021-05-05)(opens GitHub in a new tab) PullRequest kubernetes/enhancements#2672 Make PRR metadata required(opens GitHub in a new tab) Comment kubernetes/enhancements/issues/comments/832947166
2021-05-05 19:23 UTC	status_transition KEP-981 status changed from implementable to implemented in PR #2672, approved by johnbelamaric; merged by automation (k8s-ci-robot) on 2021-05-05.	@ehashman author @johnbelamaric approve_command @johnbelamaric lgtm @k8s-ci-robot merger	Commit kubernetes/enhancements@f343d8b94f8b83e8496ae42313f1290c1767bba6(opens GitHub in a new tab) StatusChange status implementable → implemented (2021-05-05)(opens GitHub in a new tab) PullRequest kubernetes/enhancements#2672 Make PRR metadata required(opens GitHub in a new tab) Comment kubernetes/enhancements/issues/comments/832947166

Metadata, label and milestone changes, oldest first.Showing 1–10 of 28Rows

Status history
At	Kind	Field	Change	Actor	Evidence
2019-04-22 23:29 UTC	label	needs-sig added	none → needs-sig	@k8s-ci-robot	source(opens GitHub in a new tab)
2019-04-22 23:29 UTC	label	sig/apps added	none → sig/apps	@k8s-ci-robot	source

Relationships as stored, Person → KEP, from kep.yaml(opens GitHub in a new tab)
Person	Relationship
@mortent GitHub(opens GitHub in a new tab)	—AUTHORED→
@kow3ns GitHub(opens GitHub in a new tab)	—REVIEWS→
@janetkuo GitHub(opens GitHub in a new tab)	—REVIEWS→
@kow3ns GitHub

How they connect

Shortest paths in the graph between this KEP and its SIG or one of its people, up to four hops.

Impact of change

Rows returned by the tool
Kep	Depth	Reached	By hop	Open pull requests	Hop	Sigs	People
{ "label": "KEP", "key": "keps/sig-apps/981-poddisruptionbudget-for-custom-resources", "title": "pdb-support-for-custom-resources-with-scale-subresource", "url": "https://github.com/kubernetes/enhancements/tree/5b503a75369bdfdd494a2c2c72107a41bf6dd1a8/keps/sig-apps/981-poddisruptionbudget-for-custom-resources", "evidence_id": "txrwv4uuuape", "number": 981, "owning_sig": "sig-apps", "status": "implemented", "stage": "stable", "latest_milestone": "v1.15", "creation_date": "2019-04-12", "last_updated": "2019-04-12", "metadata_invalid": false }	2	4	{ "1": { "sigs": 1, "people": 3 } }	not in graph (merged pull requests only)	none	none	none
none	none	none	none	none	1	[ { "label": "SIG", "key": "sig-apps", "title": "Apps", "url": "https://github.com/kubernetes/community/tree/440e496d3a172234d81728df1bfe43849b589adf/sig-apps", "evidence_id": "3xevdpgexdfq", "display_name": "Apps", "sig_label": "apps", "in_scope": true } ]	[ { "label": "Person", "key": "mortent", "title": "mortent", "url": "https://github.com/mortent", "evidence_id": "miaj4xudlac6", "login": "mortent", "is_bot": false }, { "label": "Person", "key": "kow3ns", "title": "kow3ns", "url": "https://github.com/kow3ns", "evidence_id": "z26v6kilqc4a", "login": "kow3ns", "is_bot": false }, { "label": "Person", "key": "janetkuo", "title": "janetkuo", "url": "https://github.com/janetkuo", "evidence_id": "2neu4h3gp2bm", "login": "janetkuo", "is_bot": false } ]

Rows returned by the tool
Kep	Depth	Reached	By hop	Open pull requests	Hop	Sigs	People
{ "label": "KEP", "key": "keps/sig-apps/981-poddisruptionbudget-for-custom-resources", "title": "pdb-support-for-custom-resources-with-scale-subresource", "url": "https://github.com/kubernetes/enhancements/tree/5b503a75369bdfdd494a2c2c72107a41bf6dd1a8/keps/sig-apps/981-poddisruptionbudget-for-custom-resources", "evidence_id": "txrwv4uuuape", "number": 981, "owning_sig": "sig-apps", "status": "implemented", "stage": "stable", "latest_milestone": "v1.15", "creation_date": "2019-04-12", "last_updated": "2019-04-12", "metadata_invalid": false }	2	4	{ "1": { "sigs": 1, "people": 3 } }	not in graph (merged pull requests only)	none	none	none
none	none	none	none	none	1	[ { "label": "SIG", "key": "sig-apps", "title": "Apps", "url": "https://github.com/kubernetes/community/tree/440e496d3a172234d81728df1bfe43849b589adf/sig-apps", "evidence_id": "3xevdpgexdfq", "display_name": "Apps", "sig_label": "apps", "in_scope": true } ]	[ { "label": "Person", "key": "mortent", "title": "mortent", "url": "https://github.com/mortent", "evidence_id": "miaj4xudlac6", "login": "mortent", "is_bot": false }, { "label": "Person", "key": "kow3ns", "title": "kow3ns", "url": "https://github.com/kow3ns", "evidence_id": "z26v6kilqc4a", "login": "kow3ns", "is_bot": false }, { "label": "Person", "key": "janetkuo", "title": "janetkuo", "url": "https://github.com/janetkuo", "evidence_id": "2neu4h3gp2bm", "login": "janetkuo", "is_bot": false } ]

Kep

Depth

Reached

By hop

Open pull requests

Hop

Sigs

People

{
  "label": "KEP",
  "key": "keps/sig-apps/981-poddisruptionbudget-for-custom-resources",
  "title": "pdb-support-for-custom-resources-with-scale-subresource",
  "url": "https://github.com/kubernetes/enhancements/tree/5b503a75369bdfdd494a2c2c72107a41bf6dd1a8/keps/sig-apps/981-poddisruptionbudget-for-custom-resources",
  "evidence_id": "txrwv4uuuape",
  "number": 981,
  "owning_sig": "sig-apps",
  "status": "implemented",
  "stage": "stable",
  "latest_milestone": "v1.15",
  "creation_date": "2019-04-12",
  "last_updated": "2019-04-12",
  "metadata_invalid": false
}

{
  "1": {
    "sigs": 1,
    "people": 3
  }
}

not in graph (merged pull requests only)

[
  {
    "label": "SIG",
    "key": "sig-apps",
    "title": "Apps",
    "url": "https://github.com/kubernetes/community/tree/440e496d3a172234d81728df1bfe43849b589adf/sig-apps",
    "evidence_id": "3xevdpgexdfq",
    "display_name": "Apps",
    "sig_label": "apps",
    "in_scope": true
  }
]

[
  {
    "label": "Person",
    "key": "mortent",
    "title": "mortent",
    "url": "https://github.com/mortent",
    "evidence_id": "miaj4xudlac6",
    "login": "mortent",
    "is_bot": false
  },
  {
    "label": "Person",
    "key": "kow3ns",
    "title": "kow3ns",
    "url": "https://github.com/kow3ns",
    "evidence_id": "z26v6kilqc4a",
    "login": "kow3ns",
    "is_bot": false
  },
  {
    "label": "Person",
    "key": "janetkuo",
    "title": "janetkuo",
    "url": "https://github.com/janetkuo",
    "evidence_id": "2neu4h3gp2bm",
    "login": "janetkuo",
    "is_bot": false
  }
]

MATCH (k:KEP {key: $key}) RETURN k LIMIT 1 ; MATCH (k:KEP {key: $key}) MATCH path = (k)-[:REPLACES|SUPERSEDED_BY|SEE_ALSO|GATED_BY*1..2]-(n) WHERE n <> k AND (n:KEP OR n:FeatureGate) AND all(x IN nodes(path)[1..-1] WHERE x <> k AND (x:KEP OR (x:FeatureGate AND NOT x.key IN $placeholders))) WITH n, path ORDER BY length(path), [x IN nodes(path) | x.key] WITH n, collect(path)[0] AS path RETURN n AS node, length(path) AS hop, path ORDER BY hop, n.key LIMIT 150 ; UNWIND $keys AS kk MATCH (k:KEP {key: kk}) RETURN k.key AS kep, [(k)-[r_0:OWNED_BY]->(s_0:SIG) WHERE coalesce(r_0.valid_to, $open) = $open | s_0] AS sigs, [(p_1:Person)-[r_1:AUTHORED]->(k) WHERE coalesce(r_1.valid_to, $open) = $open AND coalesce(p_1.is_bot, false) = false | p_1] AS authors, [(p_2:Person)-[r_2:APPROVES]->(k) WHERE coalesce(r_2.valid_to, $open) = $open AND coalesce(p_2.is_bot, false) = false | p_2] AS approvers, [(k)-[r_3:TRACKED_BY]->(i_3:Issue) WHERE coalesce(r_3.valid_to, $open) = $open AND i_3.state = 'open' | i_3] AS open_issues LIMIT 200

pdb-support-for-custom-resources-with-scale-subresource

Facts

How they connect

Impact of change

Keyboard shortcuts

Everywhere

Go to a page

Ask

Search lists

KEP page

Findings table

How they connect

Impact of change

Hop 1

Impact of change

Impact of change

Hop 1