KEP-950keps/sig-node/950-liveness-probe-holdoff

Add pod-startup liveness-probe holdoff for slow-starting pods

implementedstablesig-node

KEP on GitHub kep.yaml Ask about this KEP

Slow starting containers are difficult to address with the current status of health probes: they are either killed before being up, or could be left deadlocked during a very long time before being killed. This proposal adds a new probe called startupProbe that holds off all the other probes until the pod has finished its startup. In the case of a slow-start… Full summary

Facts

Authors: @matthyx
Approvers: @thockin @derekwaynecarr
Reviewers: @thockin
PRR approvers: none
Tracking issue: #950(opens GitHub in a new tab) closedcompletedclosed 2021-01-07 20:56 UTCsig/nodestage/stablekind/api-change
Milestones: none
Participating SIGs: sig-architecture sig-apps
Feature gates: none
Created / last updated: 2019-02-21 / 2020-09-16

Who decided each state, with the evidence.
Decided	Decision	Deciders	Evidence
2020-12-17 17:41 UTC	status_transition KEP-950 status set to implemented in PR #2193, approved by johnbelamaric; merged by automation (k8s-ci-robot) on 2020-12-17.	@wojtek-t author @johnbelamaric approve_command @johnbelamaric lgtm @k8s-ci-robot merger	Commit kubernetes/enhancements@7eef794bb549a50c6b08c457556ff0eac98a4c6b(opens GitHub in a new tab) StatusChange status ∅ → implemented (2020-12-17)(opens GitHub in a new tab) PullRequest kubernetes/enhancements#2193 Migrate some node KEPs to new template(opens GitHub in a new tab) Review kubernetes/enhancements/pulls/reviews/554835705(opens GitHub in a new tab)
2021-10-20 23:38 UTC	stage_graduation KEP-950 graduated to stable in PR #3007, approved by justaugustus, jeremyrickard, johnbelamaric; merged by automation (k8s-ci-robot) on 2021-10-20.	@justaugustus approver @justaugustus approve_command @justaugustus lgtm @jeremyrickard approve_command @spiffxp author @johnbelamaric approve_command @k8s-ci-robot merger	Commit kubernetes/enhancements@761668f82fef6727d2cbee10e632c371dfded529(opens GitHub in a new tab) StatusChange stage ∅ → stable (2021-10-08)(opens GitHub in a new tab) PullRequest kubernetes/enhancements#3007 pkg/kepval: enable PRR check for implemented KEPs

Metadata, label and milestone changes, oldest first.Showing 1–10 of 49Rows

Status history
At	Kind	Field	Change	Actor	Evidence
2019-04-11 06:09 UTC	label	needs-sig added	none → needs-sig	@k8s-ci-robot	source(opens GitHub in a new tab)
2019-04-11 06:09 UTC	label	sig/node added	none → sig/node	@k8s-ci-robot	source

Relationships as stored, Person → KEP, from kep.yaml(opens GitHub in a new tab)
Person	Relationship
@matthyx GitHub(opens GitHub in a new tab)	—AUTHORED→
@thockin GitHub(opens GitHub in a new tab)	—REVIEWS→
@thockin GitHub(opens GitHub in a new tab)	—APPROVES→
@derekwaynecarr

How they connect

Shortest paths in the graph between this KEP and its SIG or one of its people, up to four hops.

Impact of change

Rows returned by the tool
Kep	Depth	Reached	By hop	Open pull requests	Hop	Sigs	People
{ "label": "KEP", "key": "keps/sig-node/950-liveness-probe-holdoff", "title": "Add pod-startup liveness-probe holdoff for slow-starting pods", "url": "https://github.com/kubernetes/enhancements/tree/6ebe0a94771723b3f27cb4a757f0cc22f29e38a2/keps/sig-node/950-liveness-probe-holdoff", "evidence_id": "7g2dfnq5cvvc", "number": 950, "owning_sig": "sig-node", "status": "implemented", "stage": "stable", "creation_date": "2019-02-21", "last_updated": "2020-09-16", "metadata_invalid": false }	2	4	{ "1": { "sigs": 1, "people": 3 } }	not in graph (merged pull requests only)	none	none	none
none	none	none	none	none	1	[ { "label": "SIG", "key": "sig-node", "title": "Node", "url": "https://github.com/kubernetes/community/tree/440e496d3a172234d81728df1bfe43849b589adf/sig-node", "evidence_id": "nrsuxu2xcxa7", "display_name": "Node", "sig_label": "node", "in_scope": true } ]	[ { "label": "Person", "key": "matthyx", "title": "matthyx", "url": "https://github.com/matthyx", "evidence_id": "lkljpkveryfm", "login": "matthyx", "is_bot": false }, { "label": "Person", "key": "thockin", "title": "thockin", "url": "https://github.com/thockin", "evidence_id": "m5ydmj5ginak", "login": "thockin", "is_bot": false }, { "label": "Person", "key": "derekwaynecarr", "title": "derekwaynecarr", "url": "https://github.com/derekwaynecarr", "evidence_id": "wpnbg5qnq5fl", "login": "derekwaynecarr", "is_bot": false } ]

Rows returned by the tool
Kep	Depth	Reached	By hop	Open pull requests	Hop	Sigs	People
{ "label": "KEP", "key": "keps/sig-node/950-liveness-probe-holdoff", "title": "Add pod-startup liveness-probe holdoff for slow-starting pods", "url": "https://github.com/kubernetes/enhancements/tree/6ebe0a94771723b3f27cb4a757f0cc22f29e38a2/keps/sig-node/950-liveness-probe-holdoff", "evidence_id": "7g2dfnq5cvvc", "number": 950, "owning_sig": "sig-node", "status": "implemented", "stage": "stable", "creation_date": "2019-02-21", "last_updated": "2020-09-16", "metadata_invalid": false }	2	4	{ "1": { "sigs": 1, "people": 3 } }	not in graph (merged pull requests only)	none	none	none
none	none	none	none	none	1	[ { "label": "SIG", "key": "sig-node", "title": "Node", "url": "https://github.com/kubernetes/community/tree/440e496d3a172234d81728df1bfe43849b589adf/sig-node", "evidence_id": "nrsuxu2xcxa7", "display_name": "Node", "sig_label": "node", "in_scope": true } ]	[ { "label": "Person", "key": "matthyx", "title": "matthyx", "url": "https://github.com/matthyx", "evidence_id": "lkljpkveryfm", "login": "matthyx", "is_bot": false }, { "label": "Person", "key": "thockin", "title": "thockin", "url": "https://github.com/thockin", "evidence_id": "m5ydmj5ginak", "login": "thockin", "is_bot": false }, { "label": "Person", "key": "derekwaynecarr", "title": "derekwaynecarr", "url": "https://github.com/derekwaynecarr", "evidence_id": "wpnbg5qnq5fl", "login": "derekwaynecarr", "is_bot": false } ]

Kep

Depth

Reached

By hop

Open pull requests

Hop

Sigs

People

{
  "label": "KEP",
  "key": "keps/sig-node/950-liveness-probe-holdoff",
  "title": "Add pod-startup liveness-probe holdoff for slow-starting pods",
  "url": "https://github.com/kubernetes/enhancements/tree/6ebe0a94771723b3f27cb4a757f0cc22f29e38a2/keps/sig-node/950-liveness-probe-holdoff",
  "evidence_id": "7g2dfnq5cvvc",
  "number": 950,
  "owning_sig": "sig-node",
  "status": "implemented",
  "stage": "stable",
  "creation_date": "2019-02-21",
  "last_updated": "2020-09-16",
  "metadata_invalid": false
}

{
  "1": {
    "sigs": 1,
    "people": 3
  }
}

not in graph (merged pull requests only)

[
  {
    "label": "SIG",
    "key": "sig-node",
    "title": "Node",
    "url": "https://github.com/kubernetes/community/tree/440e496d3a172234d81728df1bfe43849b589adf/sig-node",
    "evidence_id": "nrsuxu2xcxa7",
    "display_name": "Node",
    "sig_label": "node",
    "in_scope": true
  }
]

[
  {
    "label": "Person",
    "key": "matthyx",
    "title": "matthyx",
    "url": "https://github.com/matthyx",
    "evidence_id": "lkljpkveryfm",
    "login": "matthyx",
    "is_bot": false
  },
  {
    "label": "Person",
    "key": "thockin",
    "title": "thockin",
    "url": "https://github.com/thockin",
    "evidence_id": "m5ydmj5ginak",
    "login": "thockin",
    "is_bot": false
  },
  {
    "label": "Person",
    "key": "derekwaynecarr",
    "title": "derekwaynecarr",
    "url": "https://github.com/derekwaynecarr",
    "evidence_id": "wpnbg5qnq5fl",
    "login": "derekwaynecarr",
    "is_bot": false
  }
]

MATCH (k:KEP {key: $key}) RETURN k LIMIT 1 ; MATCH (k:KEP {key: $key}) MATCH path = (k)-[:REPLACES|SUPERSEDED_BY|SEE_ALSO|GATED_BY*1..2]-(n) WHERE n <> k AND (n:KEP OR n:FeatureGate) AND all(x IN nodes(path)[1..-1] WHERE x <> k AND (x:KEP OR (x:FeatureGate AND NOT x.key IN $placeholders))) WITH n, path ORDER BY length(path), [x IN nodes(path) | x.key] WITH n, collect(path)[0] AS path RETURN n AS node, length(path) AS hop, path ORDER BY hop, n.key LIMIT 150 ; UNWIND $keys AS kk MATCH (k:KEP {key: kk}) RETURN k.key AS kep, [(k)-[r_0:OWNED_BY]->(s_0:SIG) WHERE coalesce(r_0.valid_to, $open) = $open | s_0] AS sigs, [(p_1:Person)-[r_1:AUTHORED]->(k) WHERE coalesce(r_1.valid_to, $open) = $open AND coalesce(p_1.is_bot, false) = false | p_1] AS authors, [(p_2:Person)-[r_2:APPROVES]->(k) WHERE coalesce(r_2.valid_to, $open) = $open AND coalesce(p_2.is_bot, false) = false | p_2] AS approvers, [(k)-[r_3:TRACKED_BY]->(i_3:Issue) WHERE coalesce(r_3.valid_to, $open) = $open AND i_3.state = 'open' | i_3] AS open_issues LIMIT 200

Add pod-startup liveness-probe holdoff for slow-starting pods

Facts

How they connect

Impact of change

Keyboard shortcuts

Everywhere

Go to a page

Ask

Search lists

KEP page

Findings table

How they connect

Impact of change

Hop 1

Impact of change

Impact of change

Hop 1