KEP-2360keps/sig-apps/2360-optional-service-environment-variables

Optional Service Environment Variables

provisionalsig-apps1 open finding

KEP on GitHub kep.yaml Ask about this KEP

This enhancement allows application developers to choose whether their Pods will receive environment variables from services in their namespace. They can choose to disable them via the new enableServiceLinks field in PodSpec. The current behaviour will continue to be the default behaviour, but the developer may choose to disable these environment variables f… Full summary

Facts

Authors: @kongslund @bradhoekstra
Approvers: none
Reviewers: none
PRR approvers: none
Tracking issue: #2360(opens GitHub in a new tab) closedcompletedclosed 2021-04-30 21:21 UTCsig/apps
Milestones: none
Participating SIGs: none
Feature gates: none
Created / last updated: 2018-09-25 / 2018-09-25

Who decided each state, with the evidence.
Decided	Decision	Deciders	Evidence
2021-01-30 02:05 UTC	status_transition KEP-2360 status set to provisional in PR #2361, approved by janetkuo; merged by automation (k8s-ci-robot) on 2021-01-30.	@wojtek-t lgtm @janetkuo approver @janetkuo lgtm @k8s-ci-robot merger	Commit kubernetes/enhancements@b65b2ffc7b57f7856fb55185cbaca0d523b27531(opens GitHub in a new tab) StatusChange status ∅ → provisional (2021-01-28)(opens GitHub in a new tab) PullRequest kubernetes/enhancements#2361 Migrating from old kep to new template - kep-number: 2360(opens GitHub in a new tab) Review kubernetes/enhancements/pulls/reviews/579716981(opens GitHub in a new tab) Comment kubernetes/enhancements/issues/comments/770136840(opens GitHub in a new tab) Comment kubernetes/enhancements/issues/comments/769164361(opens GitHub in a new tab)

Metadata, label and milestone changes, oldest first.Showing 1–5 of 5Rows

Status history
At	Kind	Field	Change	Actor	Evidence
2021-01-28 13:13 UTC	label	needs-sig added	none → needs-sig	@k8s-ci-robot	source(opens GitHub in a new tab)
2021-01-28 13:15 UTC	metadata	authors set	none → ["bradhoekstra","kongslund"]	none

Relationships as stored, Person → KEP, from kep.yaml(opens GitHub in a new tab)
Person	Relationship
@kongslund GitHub(opens GitHub in a new tab)	—AUTHORED→
@bradhoekstra GitHub(opens GitHub in a new tab)	—AUTHORED→

How they connect

Shortest paths in the graph between this KEP and its SIG or one of its people, up to four hops.

Impact of change

Rows returned by the tool
Kep	Depth	Reached	By hop	Open pull requests	Hop	Sigs	People
{ "label": "KEP", "key": "keps/sig-apps/2360-optional-service-environment-variables", "title": "Optional Service Environment Variables", "url": "https://github.com/kubernetes/enhancements/tree/5b503a75369bdfdd494a2c2c72107a41bf6dd1a8/keps/sig-apps/2360-optional-service-environment-variables", "evidence_id": "wkno6htjzmyg", "number": 2360, "owning_sig": "sig-apps", "status": "provisional", "creation_date": "2018-09-25", "last_updated": "2018-09-25", "metadata_invalid": false }	2	3	{ "1": { "sigs": 1, "people": 2 } }	not in graph (merged pull requests only)	none	none	none
none	none	none	none	none	1	[ { "label": "SIG", "key": "sig-apps", "title": "Apps", "url": "https://github.com/kubernetes/community/tree/440e496d3a172234d81728df1bfe43849b589adf/sig-apps", "evidence_id": "3xevdpgexdfq", "display_name": "Apps", "sig_label": "apps", "in_scope": true } ]	[ { "label": "Person", "key": "kongslund", "title": "kongslund", "url": "https://github.com/kongslund", "evidence_id": "kpux2wvns5rf", "login": "kongslund", "is_bot": false }, { "label": "Person", "key": "bradhoekstra", "title": "bradhoekstra", "url": "https://github.com/bradhoekstra", "evidence_id": "qjnk3h3nwhev", "login": "bradhoekstra", "is_bot": false } ]

Rows returned by the tool
Kep	Depth	Reached	By hop	Open pull requests	Hop	Sigs	People
{ "label": "KEP", "key": "keps/sig-apps/2360-optional-service-environment-variables", "title": "Optional Service Environment Variables", "url": "https://github.com/kubernetes/enhancements/tree/5b503a75369bdfdd494a2c2c72107a41bf6dd1a8/keps/sig-apps/2360-optional-service-environment-variables", "evidence_id": "wkno6htjzmyg", "number": 2360, "owning_sig": "sig-apps", "status": "provisional", "creation_date": "2018-09-25", "last_updated": "2018-09-25", "metadata_invalid": false }	2	3	{ "1": { "sigs": 1, "people": 2 } }	not in graph (merged pull requests only)	none	none	none
none	none	none	none	none	1	[ { "label": "SIG", "key": "sig-apps", "title": "Apps", "url": "https://github.com/kubernetes/community/tree/440e496d3a172234d81728df1bfe43849b589adf/sig-apps", "evidence_id": "3xevdpgexdfq", "display_name": "Apps", "sig_label": "apps", "in_scope": true } ]	[ { "label": "Person", "key": "kongslund", "title": "kongslund", "url": "https://github.com/kongslund", "evidence_id": "kpux2wvns5rf", "login": "kongslund", "is_bot": false }, { "label": "Person", "key": "bradhoekstra", "title": "bradhoekstra", "url": "https://github.com/bradhoekstra", "evidence_id": "qjnk3h3nwhev", "login": "bradhoekstra", "is_bot": false } ]

Kep

Depth

Reached

By hop

Open pull requests

Hop

Sigs

People

{
  "label": "KEP",
  "key": "keps/sig-apps/2360-optional-service-environment-variables",
  "title": "Optional Service Environment Variables",
  "url": "https://github.com/kubernetes/enhancements/tree/5b503a75369bdfdd494a2c2c72107a41bf6dd1a8/keps/sig-apps/2360-optional-service-environment-variables",
  "evidence_id": "wkno6htjzmyg",
  "number": 2360,
  "owning_sig": "sig-apps",
  "status": "provisional",
  "creation_date": "2018-09-25",
  "last_updated": "2018-09-25",
  "metadata_invalid": false
}

{
  "1": {
    "sigs": 1,
    "people": 2
  }
}

not in graph (merged pull requests only)

[
  {
    "label": "SIG",
    "key": "sig-apps",
    "title": "Apps",
    "url": "https://github.com/kubernetes/community/tree/440e496d3a172234d81728df1bfe43849b589adf/sig-apps",
    "evidence_id": "3xevdpgexdfq",
    "display_name": "Apps",
    "sig_label": "apps",
    "in_scope": true
  }
]

[
  {
    "label": "Person",
    "key": "kongslund",
    "title": "kongslund",
    "url": "https://github.com/kongslund",
    "evidence_id": "kpux2wvns5rf",
    "login": "kongslund",
    "is_bot": false
  },
  {
    "label": "Person",
    "key": "bradhoekstra",
    "title": "bradhoekstra",
    "url": "https://github.com/bradhoekstra",
    "evidence_id": "qjnk3h3nwhev",
    "login": "bradhoekstra",
    "is_bot": false
  }
]

MATCH (k:KEP {key: $key}) RETURN k LIMIT 1 ; MATCH (k:KEP {key: $key}) MATCH path = (k)-[:REPLACES|SUPERSEDED_BY|SEE_ALSO|GATED_BY*1..2]-(n) WHERE n <> k AND (n:KEP OR n:FeatureGate) AND all(x IN nodes(path)[1..-1] WHERE x <> k AND (x:KEP OR (x:FeatureGate AND NOT x.key IN $placeholders))) WITH n, path ORDER BY length(path), [x IN nodes(path) | x.key] WITH n, collect(path)[0] AS path RETURN n AS node, length(path) AS hop, path ORDER BY hop, n.key LIMIT 150 ; UNWIND $keys AS kk MATCH (k:KEP {key: kk}) RETURN k.key AS kep, [(k)-[r_0:OWNED_BY]->(s_0:SIG) WHERE coalesce(r_0.valid_to, $open) = $open | s_0] AS sigs, [(p_1:Person)-[r_1:AUTHORED]->(k) WHERE coalesce(r_1.valid_to, $open) = $open AND coalesce(p_1.is_bot, false) = false | p_1] AS authors, [(p_2:Person)-[r_2:APPROVES]->(k) WHERE coalesce(r_2.valid_to, $open) = $open AND coalesce(p_2.is_bot, false) = false | p_2] AS approvers, [(k)-[r_3:TRACKED_BY]->(i_3:Issue) WHERE coalesce(r_3.valid_to, $open) = $open AND i_3.state = 'open' | i_3] AS open_issues LIMIT 200

Optional Service Environment Variables

Facts

How they connect

Impact of change

Keyboard shortcuts

Everywhere

Go to a page

Ask

Search lists

KEP page

Findings table

How they connect

Impact of change

Hop 1

Impact of change

Impact of change

Hop 1