KEP-793keps/sig-node/793-node-os-arch-labels

Promote Node Operating System & Architecture labels to GA

implementablealphasig-node2 open findings

KEP on GitHub kep.yaml Ask about this KEP

The kubelet has been been labeling the Node object with operating system (OS) and architecture (arch) labels since Kubernetes 1.3. This proposal aims to promote these labels to GA and ensure a smooth transition with backward compatibility. Below lists the labels to promote: beta.kubernetes.io/os beta.kubernetes.io/arch

Facts

Authors: @yujuhong
Approvers: @dchen1107
Reviewers: @liggitt
PRR approvers: none
Tracking issue: #793(opens GitHub in a new tab) closedcompletedclosed 2019-04-11 20:26 UTCsig/nodestage/stablekind/api-change
Milestones: none
Participating SIGs: none
Feature gates: none
Created / last updated: 2019-01-30 / 2019-01-30

Who decided each state, with the evidence.
Decided	Decision	Deciders	Evidence
2020-12-17 17:41 UTC	status_transition KEP-793 status set to implementable in PR #2193, approved by johnbelamaric; merged by automation (k8s-ci-robot) on 2020-12-17.	@wojtek-t author @johnbelamaric approve_command @johnbelamaric lgtm @k8s-ci-robot merger	Commit kubernetes/enhancements@7eef794bb549a50c6b08c457556ff0eac98a4c6b(opens GitHub in a new tab) StatusChange status ∅ → implementable (2020-12-17)(opens GitHub in a new tab) PullRequest kubernetes/enhancements#2193 Migrate some node KEPs to new template(opens GitHub in a new tab) Review kubernetes/enhancements/pulls/reviews/554835705(opens GitHub in a new tab)
2021-05-05 19:23 UTC	stage_graduation KEP-793 graduated to alpha in PR #2672, approved by johnbelamaric; merged by automation (k8s-ci-robot) on 2021-05-05.	@ehashman author @johnbelamaric approve_command @johnbelamaric lgtm @k8s-ci-robot merger	Commit kubernetes/enhancements@f343d8b94f8b83e8496ae42313f1290c1767bba6(opens GitHub in a new tab) StatusChange stage ∅ → alpha (2021-05-05)(opens GitHub in a new tab) PullRequest kubernetes/enhancements#2672 Make PRR metadata required(opens GitHub in a new tab) Comment kubernetes/enhancements/issues/comments/832947166

Metadata, label and milestone changes, oldest first.Showing 1–10 of 16Rows

Status history
At	Kind	Field	Change	Actor	Evidence
2019-01-31 00:25 UTC	label	needs-sig added	none → needs-sig	@k8s-ci-robot	source(opens GitHub in a new tab)
2019-01-31 00:25 UTC	label	sig/node added	none → sig/node	@yujuhong	source

Relationships as stored, Person → KEP, from kep.yaml(opens GitHub in a new tab)
Person	Relationship
@yujuhong GitHub(opens GitHub in a new tab)	—AUTHORED→
@liggitt GitHub(opens GitHub in a new tab)	—REVIEWS→
@dchen1107 GitHub(opens GitHub in a new tab)	—APPROVES→

How they connect

Shortest paths in the graph between this KEP and its SIG or one of its people, up to four hops.

Impact of change

Rows returned by the tool
Kep	Depth	Reached	By hop	Open pull requests	Hop	Sigs	People
{ "label": "KEP", "key": "keps/sig-node/793-node-os-arch-labels", "title": "Promote Node Operating System & Architecture labels to GA", "url": "https://github.com/kubernetes/enhancements/tree/6ebe0a94771723b3f27cb4a757f0cc22f29e38a2/keps/sig-node/793-node-os-arch-labels", "evidence_id": "cak3o2sekwkx", "number": 793, "owning_sig": "sig-node", "status": "implementable", "stage": "alpha", "creation_date": "2019-01-30", "last_updated": "2019-01-30", "metadata_invalid": false }	2	3	{ "1": { "sigs": 1, "people": 2 } }	not in graph (merged pull requests only)	none	none	none
none	none	none	none	none	1	[ { "label": "SIG", "key": "sig-node", "title": "Node", "url": "https://github.com/kubernetes/community/tree/440e496d3a172234d81728df1bfe43849b589adf/sig-node", "evidence_id": "nrsuxu2xcxa7", "display_name": "Node", "sig_label": "node", "in_scope": true } ]	[ { "label": "Person", "key": "yujuhong", "title": "yujuhong", "url": "https://github.com/yujuhong", "evidence_id": "j5viftuhmt3r", "login": "yujuhong", "is_bot": false }, { "label": "Person", "key": "dchen1107", "title": "dchen1107", "url": "https://github.com/dchen1107", "evidence_id": "frhgjvzxlrsh", "login": "dchen1107", "is_bot": false } ]

Rows returned by the tool
Kep	Depth	Reached	By hop	Open pull requests	Hop	Sigs	People
{ "label": "KEP", "key": "keps/sig-node/793-node-os-arch-labels", "title": "Promote Node Operating System & Architecture labels to GA", "url": "https://github.com/kubernetes/enhancements/tree/6ebe0a94771723b3f27cb4a757f0cc22f29e38a2/keps/sig-node/793-node-os-arch-labels", "evidence_id": "cak3o2sekwkx", "number": 793, "owning_sig": "sig-node", "status": "implementable", "stage": "alpha", "creation_date": "2019-01-30", "last_updated": "2019-01-30", "metadata_invalid": false }	2	3	{ "1": { "sigs": 1, "people": 2 } }	not in graph (merged pull requests only)	none	none	none
none	none	none	none	none	1	[ { "label": "SIG", "key": "sig-node", "title": "Node", "url": "https://github.com/kubernetes/community/tree/440e496d3a172234d81728df1bfe43849b589adf/sig-node", "evidence_id": "nrsuxu2xcxa7", "display_name": "Node", "sig_label": "node", "in_scope": true } ]	[ { "label": "Person", "key": "yujuhong", "title": "yujuhong", "url": "https://github.com/yujuhong", "evidence_id": "j5viftuhmt3r", "login": "yujuhong", "is_bot": false }, { "label": "Person", "key": "dchen1107", "title": "dchen1107", "url": "https://github.com/dchen1107", "evidence_id": "frhgjvzxlrsh", "login": "dchen1107", "is_bot": false } ]

Kep

Depth

Reached

By hop

Open pull requests

Hop

Sigs

People

{
  "label": "KEP",
  "key": "keps/sig-node/793-node-os-arch-labels",
  "title": "Promote Node Operating System & Architecture labels to GA",
  "url": "https://github.com/kubernetes/enhancements/tree/6ebe0a94771723b3f27cb4a757f0cc22f29e38a2/keps/sig-node/793-node-os-arch-labels",
  "evidence_id": "cak3o2sekwkx",
  "number": 793,
  "owning_sig": "sig-node",
  "status": "implementable",
  "stage": "alpha",
  "creation_date": "2019-01-30",
  "last_updated": "2019-01-30",
  "metadata_invalid": false
}

{
  "1": {
    "sigs": 1,
    "people": 2
  }
}

not in graph (merged pull requests only)

[
  {
    "label": "SIG",
    "key": "sig-node",
    "title": "Node",
    "url": "https://github.com/kubernetes/community/tree/440e496d3a172234d81728df1bfe43849b589adf/sig-node",
    "evidence_id": "nrsuxu2xcxa7",
    "display_name": "Node",
    "sig_label": "node",
    "in_scope": true
  }
]

[
  {
    "label": "Person",
    "key": "yujuhong",
    "title": "yujuhong",
    "url": "https://github.com/yujuhong",
    "evidence_id": "j5viftuhmt3r",
    "login": "yujuhong",
    "is_bot": false
  },
  {
    "label": "Person",
    "key": "dchen1107",
    "title": "dchen1107",
    "url": "https://github.com/dchen1107",
    "evidence_id": "frhgjvzxlrsh",
    "login": "dchen1107",
    "is_bot": false
  }
]

MATCH (k:KEP {key: $key}) RETURN k LIMIT 1 ; MATCH (k:KEP {key: $key}) MATCH path = (k)-[:REPLACES|SUPERSEDED_BY|SEE_ALSO|GATED_BY*1..2]-(n) WHERE n <> k AND (n:KEP OR n:FeatureGate) AND all(x IN nodes(path)[1..-1] WHERE x <> k AND (x:KEP OR (x:FeatureGate AND NOT x.key IN $placeholders))) WITH n, path ORDER BY length(path), [x IN nodes(path) | x.key] WITH n, collect(path)[0] AS path RETURN n AS node, length(path) AS hop, path ORDER BY hop, n.key LIMIT 150 ; UNWIND $keys AS kk MATCH (k:KEP {key: kk}) RETURN k.key AS kep, [(k)-[r_0:OWNED_BY]->(s_0:SIG) WHERE coalesce(r_0.valid_to, $open) = $open | s_0] AS sigs, [(p_1:Person)-[r_1:AUTHORED]->(k) WHERE coalesce(r_1.valid_to, $open) = $open AND coalesce(p_1.is_bot, false) = false | p_1] AS authors, [(p_2:Person)-[r_2:APPROVES]->(k) WHERE coalesce(r_2.valid_to, $open) = $open AND coalesce(p_2.is_bot, false) = false | p_2] AS approvers, [(k)-[r_3:TRACKED_BY]->(i_3:Issue) WHERE coalesce(r_3.valid_to, $open) = $open AND i_3.state = 'open' | i_3] AS open_issues LIMIT 200

Promote Node Operating System & Architecture labels to GA

Facts

How they connect

Impact of change

Keyboard shortcuts

Everywhere

Go to a page

Ask

Search lists

KEP page

Findings table

How they connect

Impact of change

Hop 1

Impact of change

Impact of change

Hop 1