KEP-589keps/sig-node/589-efficient-node-heartbeats

Efficient Node Heartbeat

implementedstablesig-node

KEP on GitHub kep.yaml Ask about this KEP

Node heartbeats are necessary for correct functioning of Kubernetes cluster. This proposal makes them significantly cheaper from both scalability and performance perspective.

Facts

Authors: @wojtek-t
Approvers: @dchen1107 @derekwaynecarr
Reviewers: @deads2k @lavalamp
PRR approvers: none
Tracking issue: #589(opens GitHub in a new tab) closedcompletedclosed 2019-12-10 14:23 UTCmilestone v1.17sig/nodestage/stablekind/feature
Milestones: none
Participating SIGs: sig-scheduling sig-scalability sig-api-machinery
Feature gates: none
Created / last updated: 2018-04-27 / 2018-04-27

Who decided each state, with the evidence.
Decided	Decision	Deciders	Evidence
2020-12-17 17:41 UTC	status_transition KEP-589 status set to implemented in PR #2193, approved by johnbelamaric; merged by automation (k8s-ci-robot) on 2020-12-17.	@wojtek-t author @johnbelamaric approve_command @johnbelamaric lgtm @k8s-ci-robot merger	Commit kubernetes/enhancements@7eef794bb549a50c6b08c457556ff0eac98a4c6b(opens GitHub in a new tab) StatusChange status ∅ → implemented (2020-12-17)(opens GitHub in a new tab) PullRequest kubernetes/enhancements#2193 Migrate some node KEPs to new template(opens GitHub in a new tab) Review kubernetes/enhancements/pulls/reviews/554835705(opens GitHub in a new tab)
2021-10-20 23:38 UTC	stage_graduation KEP-589 graduated to stable in PR #3007, approved by justaugustus, jeremyrickard, johnbelamaric; merged by automation (k8s-ci-robot) on 2021-10-20.	@justaugustus approver @justaugustus approve_command @justaugustus lgtm @jeremyrickard approve_command @spiffxp author @johnbelamaric approve_command @k8s-ci-robot merger	Commit kubernetes/enhancements@761668f82fef6727d2cbee10e632c371dfded529(opens GitHub in a new tab) StatusChange stage ∅ → stable (2021-10-08)(opens GitHub in a new tab) PullRequest kubernetes/enhancements#3007 pkg/kepval: enable PRR check for implemented KEPs

Metadata, label and milestone changes, oldest first.Showing 1–10 of 42Rows

Status history
At	Kind	Field	Change	Actor	Evidence
2018-07-17 16:02 UTC	milestone	milestone milestoned	none → v1.12	@mtaufen	source(opens GitHub in a new tab)
2018-07-17 16:02 UTC	label	sig/node added	none → sig/node	@mtaufen	source

Relationships as stored, Person → KEP, from kep.yaml(opens GitHub in a new tab)
Person	Relationship
@wojtek-t GitHub(opens GitHub in a new tab)	—AUTHORED→
@deads2k GitHub(opens GitHub in a new tab)	—REVIEWS→
@lavalamp GitHub(opens GitHub in a new tab)	—REVIEWS→
@dchen1107

How they connect

Shortest paths in the graph between this KEP and its SIG or one of its people, up to four hops.

Impact of change

Rows returned by the tool
Kep	Depth	Reached	By hop	Open pull requests	Hop	Sigs	People
{ "label": "KEP", "key": "keps/sig-node/589-efficient-node-heartbeats", "title": "Efficient Node Heartbeat", "url": "https://github.com/kubernetes/enhancements/tree/6ebe0a94771723b3f27cb4a757f0cc22f29e38a2/keps/sig-node/589-efficient-node-heartbeats", "evidence_id": "bvwdcmwlu5kc", "number": 589, "owning_sig": "sig-node", "status": "implemented", "stage": "stable", "creation_date": "2018-04-27", "last_updated": "2018-04-27", "metadata_invalid": false }	2	4	{ "1": { "sigs": 1, "people": 3 } }	not in graph (merged pull requests only)	none	none	none
none	none	none	none	none	1	[ { "label": "SIG", "key": "sig-node", "title": "Node", "url": "https://github.com/kubernetes/community/tree/440e496d3a172234d81728df1bfe43849b589adf/sig-node", "evidence_id": "nrsuxu2xcxa7", "display_name": "Node", "sig_label": "node", "in_scope": true } ]	[ { "label": "Person", "key": "wojtek-t", "title": "wojtek-t", "url": "https://github.com/wojtek-t", "evidence_id": "wvpmhj7c3dox", "login": "wojtek-t", "is_bot": false }, { "label": "Person", "key": "dchen1107", "title": "dchen1107", "url": "https://github.com/dchen1107", "evidence_id": "frhgjvzxlrsh", "login": "dchen1107", "is_bot": false }, { "label": "Person", "key": "derekwaynecarr", "title": "derekwaynecarr", "url": "https://github.com/derekwaynecarr", "evidence_id": "wpnbg5qnq5fl", "login": "derekwaynecarr", "is_bot": false } ]

Rows returned by the tool
Kep	Depth	Reached	By hop	Open pull requests	Hop	Sigs	People
{ "label": "KEP", "key": "keps/sig-node/589-efficient-node-heartbeats", "title": "Efficient Node Heartbeat", "url": "https://github.com/kubernetes/enhancements/tree/6ebe0a94771723b3f27cb4a757f0cc22f29e38a2/keps/sig-node/589-efficient-node-heartbeats", "evidence_id": "bvwdcmwlu5kc", "number": 589, "owning_sig": "sig-node", "status": "implemented", "stage": "stable", "creation_date": "2018-04-27", "last_updated": "2018-04-27", "metadata_invalid": false }	2	4	{ "1": { "sigs": 1, "people": 3 } }	not in graph (merged pull requests only)	none	none	none
none	none	none	none	none	1	[ { "label": "SIG", "key": "sig-node", "title": "Node", "url": "https://github.com/kubernetes/community/tree/440e496d3a172234d81728df1bfe43849b589adf/sig-node", "evidence_id": "nrsuxu2xcxa7", "display_name": "Node", "sig_label": "node", "in_scope": true } ]	[ { "label": "Person", "key": "wojtek-t", "title": "wojtek-t", "url": "https://github.com/wojtek-t", "evidence_id": "wvpmhj7c3dox", "login": "wojtek-t", "is_bot": false }, { "label": "Person", "key": "dchen1107", "title": "dchen1107", "url": "https://github.com/dchen1107", "evidence_id": "frhgjvzxlrsh", "login": "dchen1107", "is_bot": false }, { "label": "Person", "key": "derekwaynecarr", "title": "derekwaynecarr", "url": "https://github.com/derekwaynecarr", "evidence_id": "wpnbg5qnq5fl", "login": "derekwaynecarr", "is_bot": false } ]

Kep

Depth

Reached

By hop

Open pull requests

Hop

Sigs

People

{
  "label": "KEP",
  "key": "keps/sig-node/589-efficient-node-heartbeats",
  "title": "Efficient Node Heartbeat",
  "url": "https://github.com/kubernetes/enhancements/tree/6ebe0a94771723b3f27cb4a757f0cc22f29e38a2/keps/sig-node/589-efficient-node-heartbeats",
  "evidence_id": "bvwdcmwlu5kc",
  "number": 589,
  "owning_sig": "sig-node",
  "status": "implemented",
  "stage": "stable",
  "creation_date": "2018-04-27",
  "last_updated": "2018-04-27",
  "metadata_invalid": false
}

{
  "1": {
    "sigs": 1,
    "people": 3
  }
}

not in graph (merged pull requests only)

[
  {
    "label": "SIG",
    "key": "sig-node",
    "title": "Node",
    "url": "https://github.com/kubernetes/community/tree/440e496d3a172234d81728df1bfe43849b589adf/sig-node",
    "evidence_id": "nrsuxu2xcxa7",
    "display_name": "Node",
    "sig_label": "node",
    "in_scope": true
  }
]

[
  {
    "label": "Person",
    "key": "wojtek-t",
    "title": "wojtek-t",
    "url": "https://github.com/wojtek-t",
    "evidence_id": "wvpmhj7c3dox",
    "login": "wojtek-t",
    "is_bot": false
  },
  {
    "label": "Person",
    "key": "dchen1107",
    "title": "dchen1107",
    "url": "https://github.com/dchen1107",
    "evidence_id": "frhgjvzxlrsh",
    "login": "dchen1107",
    "is_bot": false
  },
  {
    "label": "Person",
    "key": "derekwaynecarr",
    "title": "derekwaynecarr",
    "url": "https://github.com/derekwaynecarr",
    "evidence_id": "wpnbg5qnq5fl",
    "login": "derekwaynecarr",
    "is_bot": false
  }
]

MATCH (k:KEP {key: $key}) RETURN k LIMIT 1 ; MATCH (k:KEP {key: $key}) MATCH path = (k)-[:REPLACES|SUPERSEDED_BY|SEE_ALSO|GATED_BY*1..2]-(n) WHERE n <> k AND (n:KEP OR n:FeatureGate) AND all(x IN nodes(path)[1..-1] WHERE x <> k AND (x:KEP OR (x:FeatureGate AND NOT x.key IN $placeholders))) WITH n, path ORDER BY length(path), [x IN nodes(path) | x.key] WITH n, collect(path)[0] AS path RETURN n AS node, length(path) AS hop, path ORDER BY hop, n.key LIMIT 150 ; UNWIND $keys AS kk MATCH (k:KEP {key: kk}) RETURN k.key AS kep, [(k)-[r_0:OWNED_BY]->(s_0:SIG) WHERE coalesce(r_0.valid_to, $open) = $open | s_0] AS sigs, [(p_1:Person)-[r_1:AUTHORED]->(k) WHERE coalesce(r_1.valid_to, $open) = $open AND coalesce(p_1.is_bot, false) = false | p_1] AS authors, [(p_2:Person)-[r_2:APPROVES]->(k) WHERE coalesce(r_2.valid_to, $open) = $open AND coalesce(p_2.is_bot, false) = false | p_2] AS approvers, [(k)-[r_3:TRACKED_BY]->(i_3:Issue) WHERE coalesce(r_3.valid_to, $open) = $open AND i_3.state = 'open' | i_3] AS open_issues LIMIT 200

Efficient Node Heartbeat

Facts

How they connect

Impact of change

Keyboard shortcuts

Everywhere

Go to a page

Ask

Search lists

KEP page

Findings table

How they connect

Impact of change

Hop 1

Impact of change

Impact of change

Hop 1