KEP-382keps/sig-scheduling/382-taint-node-by-condition

Graduate TaintNodeByCondition to GA

KEP on GitHub kep.yaml Ask about this KEP

TaintNodeByCondition has been created in the past to taint node by their conditions. We wish to graduate TaintNodeByCondition feature to make scheduling decisions based on taints instead of node conditions in the scheduler.

Facts

Authors: @draveness
Approvers: @k82cn
Reviewers: @k82cn
PRR approvers: none
Tracking issue: #382(opens GitHub in a new tab) closedcompletedclosed 2020-01-03 16:07 UTCmilestone v1.17sig/nodesig/schedulingstage/stablekind/feature
Milestones: none
Participating SIGs: sig-node
Feature gates: none
Created / last updated: 2019-10-12 / 2019-10-12

Who decided each state, with the evidence.
Decided	Decision	Deciders	Evidence
2020-12-17 19:35 UTC	status_transition KEP-382 status set to implemented in PR #2195, approved by johnbelamaric; merged by automation (k8s-ci-robot) on 2020-12-17.	@wojtek-t author @johnbelamaric approve_command @johnbelamaric lgtm @k8s-ci-robot merger	Commit kubernetes/enhancements@39f2aa584633fea9948f85ffdcca3643a414330a(opens GitHub in a new tab) StatusChange status ∅ → implemented (2020-12-17)(opens GitHub in a new tab) PullRequest kubernetes/enhancements#2195 Migrate some scheduling KEPs to new template(opens GitHub in a new tab) Comment kubernetes/enhancements/issues/comments/747653083(opens GitHub in a new tab)
2021-10-20 23:38 UTC	stage_graduation KEP-382 graduated to stable in PR #3007, approved by justaugustus, jeremyrickard, johnbelamaric; merged by automation (k8s-ci-robot) on 2021-10-20.	@justaugustus approver @justaugustus approve_command @justaugustus lgtm @jeremyrickard approve_command @spiffxp author @johnbelamaric approve_command @k8s-ci-robot merger	Commit kubernetes/enhancements@761668f82fef6727d2cbee10e632c371dfded529(opens GitHub in a new tab) StatusChange stage ∅ → stable (2021-10-08)(opens GitHub in a new tab) PullRequest kubernetes/enhancements#3007 pkg/kepval: enable PRR check for implemented KEPs

Metadata, label and milestone changes, oldest first.Showing 1–10 of 33Rows

Status history
At	Kind	Field	Change	Actor	Evidence
2017-08-09 13:57 UTC	label	sig/scheduling added	none → sig/scheduling	@idvoretskyi	source(opens GitHub in a new tab)
2017-08-23 14:12 UTC	milestone	milestone milestoned	none → v1.8	@jdumars	source

Relationships as stored, Person → KEP, from kep.yaml(opens GitHub in a new tab)
Person	Relationship
@draveness GitHub(opens GitHub in a new tab)	—AUTHORED→
@k82cn GitHub(opens GitHub in a new tab)	—REVIEWS→
@k82cn GitHub(opens GitHub in a new tab)	—APPROVES→

How they connect

Shortest paths in the graph between this KEP and its SIG or one of its people, up to four hops.

Impact of change

Rows returned by the tool
Kep	Depth	Reached	By hop	Open pull requests	Hop	Sigs	People
{ "label": "KEP", "key": "keps/sig-scheduling/382-taint-node-by-condition", "title": "Graduate TaintNodeByCondition to GA", "url": "https://github.com/kubernetes/enhancements/tree/6ebe0a94771723b3f27cb4a757f0cc22f29e38a2/keps/sig-scheduling/382-taint-node-by-condition", "evidence_id": "lanvkrbbhztz", "number": 382, "owning_sig": "sig-scheduling", "status": "implemented", "stage": "stable", "creation_date": "2019-10-12", "last_updated": "2019-10-12", "metadata_invalid": false }	2	3	{ "1": { "sigs": 1, "people": 2 } }	not in graph (merged pull requests only)	none	none	none
none	none	none	none	none	1	[ { "label": "SIG", "key": "sig-scheduling", "title": "Scheduling", "url": "https://github.com/kubernetes/community/tree/440e496d3a172234d81728df1bfe43849b589adf/sig-scheduling", "evidence_id": "maif65vfeb5k", "display_name": "Scheduling", "sig_label": "scheduling", "in_scope": true } ]	[ { "label": "Person", "key": "draveness", "title": "draveness", "url": "https://github.com/draveness", "evidence_id": "b3ejjc2ed7op", "login": "draveness", "is_bot": false }, { "label": "Person", "key": "k82cn", "title": "k82cn", "url": "https://github.com/k82cn", "evidence_id": "obumrms3yrzd", "login": "k82cn", "is_bot": false } ]

Rows returned by the tool
Kep	Depth	Reached	By hop	Open pull requests	Hop	Sigs	People
{ "label": "KEP", "key": "keps/sig-scheduling/382-taint-node-by-condition", "title": "Graduate TaintNodeByCondition to GA", "url": "https://github.com/kubernetes/enhancements/tree/6ebe0a94771723b3f27cb4a757f0cc22f29e38a2/keps/sig-scheduling/382-taint-node-by-condition", "evidence_id": "lanvkrbbhztz", "number": 382, "owning_sig": "sig-scheduling", "status": "implemented", "stage": "stable", "creation_date": "2019-10-12", "last_updated": "2019-10-12", "metadata_invalid": false }	2	3	{ "1": { "sigs": 1, "people": 2 } }	not in graph (merged pull requests only)	none	none	none
none	none	none	none	none	1	[ { "label": "SIG", "key": "sig-scheduling", "title": "Scheduling", "url": "https://github.com/kubernetes/community/tree/440e496d3a172234d81728df1bfe43849b589adf/sig-scheduling", "evidence_id": "maif65vfeb5k", "display_name": "Scheduling", "sig_label": "scheduling", "in_scope": true } ]	[ { "label": "Person", "key": "draveness", "title": "draveness", "url": "https://github.com/draveness", "evidence_id": "b3ejjc2ed7op", "login": "draveness", "is_bot": false }, { "label": "Person", "key": "k82cn", "title": "k82cn", "url": "https://github.com/k82cn", "evidence_id": "obumrms3yrzd", "login": "k82cn", "is_bot": false } ]

Kep

Depth

Reached

By hop

Open pull requests

Hop

Sigs

People

{
  "label": "KEP",
  "key": "keps/sig-scheduling/382-taint-node-by-condition",
  "title": "Graduate TaintNodeByCondition to GA",
  "url": "https://github.com/kubernetes/enhancements/tree/6ebe0a94771723b3f27cb4a757f0cc22f29e38a2/keps/sig-scheduling/382-taint-node-by-condition",
  "evidence_id": "lanvkrbbhztz",
  "number": 382,
  "owning_sig": "sig-scheduling",
  "status": "implemented",
  "stage": "stable",
  "creation_date": "2019-10-12",
  "last_updated": "2019-10-12",
  "metadata_invalid": false
}

{
  "1": {
    "sigs": 1,
    "people": 2
  }
}

not in graph (merged pull requests only)

[
  {
    "label": "SIG",
    "key": "sig-scheduling",
    "title": "Scheduling",
    "url": "https://github.com/kubernetes/community/tree/440e496d3a172234d81728df1bfe43849b589adf/sig-scheduling",
    "evidence_id": "maif65vfeb5k",
    "display_name": "Scheduling",
    "sig_label": "scheduling",
    "in_scope": true
  }
]

[
  {
    "label": "Person",
    "key": "draveness",
    "title": "draveness",
    "url": "https://github.com/draveness",
    "evidence_id": "b3ejjc2ed7op",
    "login": "draveness",
    "is_bot": false
  },
  {
    "label": "Person",
    "key": "k82cn",
    "title": "k82cn",
    "url": "https://github.com/k82cn",
    "evidence_id": "obumrms3yrzd",
    "login": "k82cn",
    "is_bot": false
  }
]

MATCH (k:KEP {key: $key}) RETURN k LIMIT 1 ; MATCH (k:KEP {key: $key}) MATCH path = (k)-[:REPLACES|SUPERSEDED_BY|SEE_ALSO|GATED_BY*1..2]-(n) WHERE n <> k AND (n:KEP OR n:FeatureGate) AND all(x IN nodes(path)[1..-1] WHERE x <> k AND (x:KEP OR (x:FeatureGate AND NOT x.key IN $placeholders))) WITH n, path ORDER BY length(path), [x IN nodes(path) | x.key] WITH n, collect(path)[0] AS path RETURN n AS node, length(path) AS hop, path ORDER BY hop, n.key LIMIT 150 ; UNWIND $keys AS kk MATCH (k:KEP {key: kk}) RETURN k.key AS kep, [(k)-[r_0:OWNED_BY]->(s_0:SIG) WHERE coalesce(r_0.valid_to, $open) = $open | s_0] AS sigs, [(p_1:Person)-[r_1:AUTHORED]->(k) WHERE coalesce(r_1.valid_to, $open) = $open AND coalesce(p_1.is_bot, false) = false | p_1] AS authors, [(p_2:Person)-[r_2:APPROVES]->(k) WHERE coalesce(r_2.valid_to, $open) = $open AND coalesce(p_2.is_bot, false) = false | p_2] AS approvers, [(k)-[r_3:TRACKED_BY]->(i_3:Issue) WHERE coalesce(r_3.valid_to, $open) = $open AND i_3.state = 'open' | i_3] AS open_issues LIMIT 200

Graduate TaintNodeByCondition to GA

Facts

How they connect

Impact of change

Keyboard shortcuts

Everywhere

Go to a page

Ask

Search lists

KEP page

Findings table

How they connect

Impact of change

Hop 1

Impact of change

Impact of change

Hop 1