KEP-2411keps/sig-node/2411-cri-container-log-rotation

CRI Container Log Rotation

implementedstablesig-nodelatest v1.21

KEP on GitHub kep.yaml Ask about this KEP

The CRIContainerLogRotation feature gate was implemented in v1.10 and has been in Beta stage since v1.11. We would like to identify any gaps in the implementation of this feature so that we can promote it to stable as it has already been in production use for quite some time now. With this feature gate, the kubelet is in charge of managing the container log… Full summary

Facts

Authors: @umohnani8
Approvers: @mrunalp @derekwaynecarr
Reviewers: @mrunalp @sergeykanzhelev
PRR approvers: @deads2kstable
Tracking issue: #2411(opens GitHub in a new tab) closedcompletedclosed 2021-04-08 15:41 UTCmilestone v1.21sig/nodestage/stable
Milestones: alpha v1.10beta v1.11stable v1.21
Participating SIGs: sig-storage sig-instrumentation
Feature gates: CRIContainerLogRotation
Created / last updated: 2018-01-25 / none

Who decided each state, with the evidence.
Decided	Decision	Deciders	Evidence
2021-02-03 20:01 UTC	prr_approval deads2k gave the production readiness approval for KEP-2411 at stable on 2021-02-03.	@deads2k prr_approver	Document 2411.yaml(opens GitHub in a new tab)
2021-02-09 16:55 UTC	stage_graduation KEP-2411 set milestone.alpha to v1.10 in PR #2418, approved by deads2k, derekwaynecarr; merged by automation (k8s-ci-robot) on 2021-02-09.	@derekwaynecarr approve_command @derekwaynecarr lgtm @deads2k approve_command @umohnani8 author @k8s-ci-robot merger	Commit kubernetes/enhancements@4885227c4c9c51d3e8015f224d158ae2b1a9a3e3(opens GitHub in a new tab) StatusChange milestone.alpha ∅ → v1.10 (2021-02-03)(opens GitHub in a new tab) PullRequest kubernetes/enhancements#2418 Add KEP for enabling CRIContainerLogRotation by default(opens GitHub in a new tab) Comment kubernetes/enhancements/issues/comments/776077585(opens GitHub in a new tab) Comment kubernetes/enhancements/issues/comments/776059097(opens GitHub in a new tab)
2021-02-09 16:55 UTC	stage_graduation KEP-2411 set milestone.beta to v1.11 in PR #2418, approved by deads2k, derekwaynecarr; merged by automation (k8s-ci-robot) on 2021-02-09.	@derekwaynecarr approve_command @derekwaynecarr lgtm @deads2k approve_command @umohnani8 author @k8s-ci-robot merger	Commit kubernetes/enhancements@4885227c4c9c51d3e8015f224d158ae2b1a9a3e3(opens GitHub in a new tab) StatusChange milestone.beta ∅ → v1.11 (2021-02-03)(opens GitHub in a new tab) PullRequest kubernetes/enhancements#2418 Add KEP for enabling CRIContainerLogRotation by default(opens GitHub in a new tab) Comment
2021-02-09 16:55 UTC	stage_graduation KEP-2411 set milestone.stable to v1.21 in PR #2418, approved by deads2k, derekwaynecarr; merged by automation (k8s-ci-robot) on 2021-02-09.	@derekwaynecarr approve_command @derekwaynecarr lgtm @deads2k approve_command @umohnani8 author @k8s-ci-robot merger	Commit kubernetes/enhancements@4885227c4c9c51d3e8015f224d158ae2b1a9a3e3(opens GitHub in a new tab) StatusChange milestone.stable ∅ → v1.21 (2021-02-03)(opens GitHub in a new tab) PullRequest kubernetes/enhancements#2418 Add KEP for enabling CRIContainerLogRotation by default(opens GitHub in a new tab) Comment
2021-02-09 16:55 UTC	stage_graduation KEP-2411 graduated to stable in PR #2418, approved by deads2k, derekwaynecarr; merged by automation (k8s-ci-robot) on 2021-02-09.	@derekwaynecarr approve_command @derekwaynecarr lgtm @deads2k approve_command @umohnani8 author @k8s-ci-robot merger	Commit kubernetes/enhancements@4885227c4c9c51d3e8015f224d158ae2b1a9a3e3(opens GitHub in a new tab) StatusChange stage ∅ → stable (2021-02-03)(opens GitHub in a new tab) PullRequest kubernetes/enhancements#2418 Add KEP for enabling CRIContainerLogRotation by default(opens GitHub in a new tab) Comment kubernetes/enhancements/issues/comments/776077585
2021-02-09 16:55 UTC	status_transition KEP-2411 status set to implemented in PR #2418, approved by deads2k, derekwaynecarr; merged by automation (k8s-ci-robot) on 2021-02-09.	@derekwaynecarr approve_command @derekwaynecarr lgtm @deads2k approve_command @umohnani8 author @k8s-ci-robot merger	Commit kubernetes/enhancements@4885227c4c9c51d3e8015f224d158ae2b1a9a3e3(opens GitHub in a new tab) StatusChange status ∅ → implemented (2021-02-03)(opens GitHub in a new tab) PullRequest kubernetes/enhancements#2418 Add KEP for enabling CRIContainerLogRotation by default(opens GitHub in a new tab) Comment

Metadata, label and milestone changes, oldest first.Showing 1–10 of 18Rows

Status history
At	Kind	Field	Change	Actor	Evidence
2021-02-03 01:13 UTC	label	sig/node added	none → sig/node	@k8s-ci-robot	source(opens GitHub in a new tab)
2021-02-03 20:01 UTC	metadata	approvers set	none → ["derekwaynecarr","mrunalp"]	none

Relationships as stored, Person → KEP, from kep.yaml(opens GitHub in a new tab)
Person	Relationship
@umohnani8 GitHub(opens GitHub in a new tab)	—AUTHORED→
@mrunalp GitHub(opens GitHub in a new tab)	—REVIEWS→
@sergeykanzhelev GitHub(opens GitHub in a new tab)	—REVIEWS→
@mrunalp

How they connect

Shortest paths in the graph between this KEP and its SIG or one of its people, up to four hops.

Impact of change

Rows returned by the tool
Kep	Depth	Reached	By hop	Open pull requests	Hop	Feature gates	Sigs	People
{ "label": "KEP", "key": "keps/sig-node/2411-cri-container-log-rotation", "title": "CRI Container Log Rotation", "url": "https://github.com/kubernetes/enhancements/tree/5b503a75369bdfdd494a2c2c72107a41bf6dd1a8/keps/sig-node/2411-cri-container-log-rotation", "evidence_id": "mgb33ex5iqqq", "number": 2411, "owning_sig": "sig-node", "status": "implemented", "stage": "stable", "latest_milestone": "v1.21", "milestone_alpha": "v1.10", "milestone_beta": "v1.11", "milestone_stable": "v1.21", "creation_date": "2018-01-25", "metadata_invalid": false }	2	5	{ "1": { "feature_gates": 1, "sigs": 1, "people": 3 } }	not in graph (merged pull requests only)	none	none	none	none
none	none	none	none	none	1	[ { "label": "FeatureGate", "key": "CRIContainerLogRotation", "title": "CRIContainerLogRotation", "url": "https://github.com/kubernetes/enhancements/blob/5b503a75369bdfdd494a2c2c72107a41bf6dd1a8/keps/sig-node/2411-cri-container-log-rotation/kep.yaml", "evidence_id": "tyajfw542o6q", "name": "CRIContainerLogRotation" } ]	[ { "label": "SIG", "key": "sig-node", "title": "Node", "url": "https://github.com/kubernetes/community/tree/440e496d3a172234d81728df1bfe43849b589adf/sig-node", "evidence_id": "nrsuxu2xcxa7", "display_name": "Node", "sig_label": "node", "in_scope": true } ]	[ { "label": "Person", "key": "umohnani8", "title": "umohnani8", "url": "https://github.com/umohnani8", "evidence_id": "6upmlkblramj", "login": "umohnani8", "is_bot": false }, { "label": "Person", "key": "mrunalp", "title": "mrunalp", "url": "https://github.com/mrunalp", "evidence_id": "oysq4hgp6yuk", "login": "mrunalp", "is_bot": false }, { "label": "Person", "key": "derekwaynecarr", "title": "derekwaynecarr", "url": "https://github.com/derekwaynecarr", "evidence_id": "wpnbg5qnq5fl", "login": "derekwaynecarr", "is_bot": false } ]

Rows returned by the tool
Kep	Depth	Reached	By hop	Open pull requests	Hop	Feature gates	Sigs	People
{ "label": "KEP", "key": "keps/sig-node/2411-cri-container-log-rotation", "title": "CRI Container Log Rotation", "url": "https://github.com/kubernetes/enhancements/tree/5b503a75369bdfdd494a2c2c72107a41bf6dd1a8/keps/sig-node/2411-cri-container-log-rotation", "evidence_id": "mgb33ex5iqqq", "number": 2411, "owning_sig": "sig-node", "status": "implemented", "stage": "stable", "latest_milestone": "v1.21", "milestone_alpha": "v1.10", "milestone_beta": "v1.11", "milestone_stable": "v1.21", "creation_date": "2018-01-25", "metadata_invalid": false }	2	5	{ "1": { "feature_gates": 1, "sigs": 1, "people": 3 } }	not in graph (merged pull requests only)	none	none	none	none
none	none	none	none	none	1	[ { "label": "FeatureGate", "key": "CRIContainerLogRotation", "title": "CRIContainerLogRotation", "url": "https://github.com/kubernetes/enhancements/blob/5b503a75369bdfdd494a2c2c72107a41bf6dd1a8/keps/sig-node/2411-cri-container-log-rotation/kep.yaml", "evidence_id": "tyajfw542o6q", "name": "CRIContainerLogRotation" } ]	[ { "label": "SIG", "key": "sig-node", "title": "Node", "url": "https://github.com/kubernetes/community/tree/440e496d3a172234d81728df1bfe43849b589adf/sig-node", "evidence_id": "nrsuxu2xcxa7", "display_name": "Node", "sig_label": "node", "in_scope": true } ]	[ { "label": "Person", "key": "umohnani8", "title": "umohnani8", "url": "https://github.com/umohnani8", "evidence_id": "6upmlkblramj", "login": "umohnani8", "is_bot": false }, { "label": "Person", "key": "mrunalp", "title": "mrunalp", "url": "https://github.com/mrunalp", "evidence_id": "oysq4hgp6yuk", "login": "mrunalp", "is_bot": false }, { "label": "Person", "key": "derekwaynecarr", "title": "derekwaynecarr", "url": "https://github.com/derekwaynecarr", "evidence_id": "wpnbg5qnq5fl", "login": "derekwaynecarr", "is_bot": false } ]

Kep

Depth

Reached

By hop

Open pull requests

Hop

Feature gates

Sigs

People

{
  "label": "KEP",
  "key": "keps/sig-node/2411-cri-container-log-rotation",
  "title": "CRI Container Log Rotation",
  "url": "https://github.com/kubernetes/enhancements/tree/5b503a75369bdfdd494a2c2c72107a41bf6dd1a8/keps/sig-node/2411-cri-container-log-rotation",
  "evidence_id": "mgb33ex5iqqq",
  "number": 2411,
  "owning_sig": "sig-node",
  "status": "implemented",
  "stage": "stable",
  "latest_milestone": "v1.21",
  "milestone_alpha": "v1.10",
  "milestone_beta": "v1.11",
  "milestone_stable": "v1.21",
  "creation_date": "2018-01-25",
  "metadata_invalid": false
}

{
  "1": {
    "feature_gates": 1,
    "sigs": 1,
    "people": 3
  }
}

not in graph (merged pull requests only)

[
  {
    "label": "FeatureGate",
    "key": "CRIContainerLogRotation",
    "title": "CRIContainerLogRotation",
    "url": "https://github.com/kubernetes/enhancements/blob/5b503a75369bdfdd494a2c2c72107a41bf6dd1a8/keps/sig-node/2411-cri-container-log-rotation/kep.yaml",
    "evidence_id": "tyajfw542o6q",
    "name": "CRIContainerLogRotation"
  }
]

[
  {
    "label": "SIG",
    "key": "sig-node",
    "title": "Node",
    "url": "https://github.com/kubernetes/community/tree/440e496d3a172234d81728df1bfe43849b589adf/sig-node",
    "evidence_id": "nrsuxu2xcxa7",
    "display_name": "Node",
    "sig_label": "node",
    "in_scope": true
  }
]

[
  {
    "label": "Person",
    "key": "umohnani8",
    "title": "umohnani8",
    "url": "https://github.com/umohnani8",
    "evidence_id": "6upmlkblramj",
    "login": "umohnani8",
    "is_bot": false
  },
  {
    "label": "Person",
    "key": "mrunalp",
    "title": "mrunalp",
    "url": "https://github.com/mrunalp",
    "evidence_id": "oysq4hgp6yuk",
    "login": "mrunalp",
    "is_bot": false
  },
  {
    "label": "Person",
    "key": "derekwaynecarr",
    "title": "derekwaynecarr",
    "url": "https://github.com/derekwaynecarr",
    "evidence_id": "wpnbg5qnq5fl",
    "login": "derekwaynecarr",
    "is_bot": false
  }
]

MATCH (k:KEP {key: $key}) RETURN k LIMIT 1 ; MATCH (k:KEP {key: $key}) MATCH path = (k)-[:REPLACES|SUPERSEDED_BY|SEE_ALSO|GATED_BY*1..2]-(n) WHERE n <> k AND (n:KEP OR n:FeatureGate) AND all(x IN nodes(path)[1..-1] WHERE x <> k AND (x:KEP OR (x:FeatureGate AND NOT x.key IN $placeholders))) WITH n, path ORDER BY length(path), [x IN nodes(path) | x.key] WITH n, collect(path)[0] AS path RETURN n AS node, length(path) AS hop, path ORDER BY hop, n.key LIMIT 150 ; UNWIND $keys AS kk MATCH (k:KEP {key: kk}) RETURN k.key AS kep, [(k)-[r_0:OWNED_BY]->(s_0:SIG) WHERE coalesce(r_0.valid_to, $open) = $open | s_0] AS sigs, [(p_1:Person)-[r_1:AUTHORED]->(k) WHERE coalesce(r_1.valid_to, $open) = $open AND coalesce(p_1.is_bot, false) = false | p_1] AS authors, [(p_2:Person)-[r_2:APPROVES]->(k) WHERE coalesce(r_2.valid_to, $open) = $open AND coalesce(p_2.is_bot, false) = false | p_2] AS approvers, [(k)-[r_3:TRACKED_BY]->(i_3:Issue) WHERE coalesce(r_3.valid_to, $open) = $open AND i_3.state = 'open' | i_3] AS open_issues LIMIT 200

CRI Container Log Rotation

Facts

How they connect

Impact of change

Keyboard shortcuts

Everywhere

Go to a page

Ask

Search lists

KEP page

Findings table

How they connect

Impact of change

Hop 1

Impact of change

Impact of change

Hop 1