KEP-1923keps/sig-scheduling/1923-prefer-nominated-node

Prefer Nominated Node

implementedstablesig-schedulinglatest v1.242 open findings

KEP on GitHub kep.yaml Ask about this KEP

This KEP proposes to change the scheduling cycle such that nominated node of a pod is evaluated first and schedule the pod on that node if it fits. If the nominated node doesn't fit the pod, only then the scheduling cycle continues with the standard logic of evaluating the rest of the nodes in the cluster.

Facts

Authors: @chendave
Approvers: @ahg-g @huang-wei
Reviewers: @alculquicondor @ahg-g @huang-wei
PRR approvers: @wojtek-talpha@wojtek-tbeta@wojtek-tstable
Tracking issue: #1923(opens GitHub in a new tab) closedcompletedclosed 2022-03-25 02:04 UTCmilestone v1.22sig/schedulingstage/beta
Milestones: alpha v1.21beta v1.22stable v1.24
Participating SIGs: none
Feature gates: PreferNominatedNode
Created / last updated: 2020-09-29 / none

Who decided each state, with the evidence.
Decided	Decision	Deciders	Evidence
2020-10-27 22:17 UTC	stage_graduation KEP-1923 set milestone.alpha to v1.21 in PR #2026, approved by ahg-g; merged by automation (k8s-ci-robot) on 2020-10-27.	@alculquicondor lgtm @ahg-g approve_command @huang-wei lgtm @chendave author @k8s-ci-robot merger	Commit kubernetes/enhancements@1a81f090c5f9c86c34bdf94733247a4b0381e7f7(opens GitHub in a new tab) StatusChange milestone.alpha ∅ → v1.21 (2020-09-29)(opens GitHub in a new tab) PullRequest kubernetes/enhancements#2026 Add KEP 1923 - prefer nominated node(opens GitHub in a new tab) Comment kubernetes/enhancements/issues/comments/717504158(opens GitHub in a new tab) Comment kubernetes/enhancements/issues/comments/715414060(opens GitHub in a new tab) Comment kubernetes/enhancements/issues/comments/715364769(opens GitHub in a new tab)
2020-10-27 22:17 UTC	stage_graduation KEP-1923 set milestone.beta to v1.22 in PR #2026, approved by ahg-g; merged by automation (k8s-ci-robot) on 2020-10-27.	@alculquicondor lgtm @ahg-g approve_command @huang-wei lgtm @chendave author @k8s-ci-robot merger	Commit kubernetes/enhancements@1a81f090c5f9c86c34bdf94733247a4b0381e7f7(opens GitHub in a new tab) StatusChange milestone.beta ∅ → v1.22 (2020-09-29)(opens GitHub in a new tab) PullRequest kubernetes/enhancements#2026 Add KEP 1923 - prefer nominated node(opens GitHub in a new tab) Comment kubernetes/enhancements/issues/comments/717504158
2020-10-27 22:17 UTC	stage_graduation KEP-1923 set milestone.stable to v1.24 in PR #2026, approved by ahg-g; merged by automation (k8s-ci-robot) on 2020-10-27.	@alculquicondor lgtm @ahg-g approve_command @huang-wei lgtm @chendave author @k8s-ci-robot merger	Commit kubernetes/enhancements@1a81f090c5f9c86c34bdf94733247a4b0381e7f7(opens GitHub in a new tab) StatusChange milestone.stable ∅ → v1.24 (2020-09-29)(opens GitHub in a new tab) PullRequest kubernetes/enhancements#2026 Add KEP 1923 - prefer nominated node(opens GitHub in a new tab) Comment kubernetes/enhancements/issues/comments/717504158
2020-10-27 22:17 UTC	stage_graduation KEP-1923 graduated to alpha in PR #2026, approved by ahg-g; merged by automation (k8s-ci-robot) on 2020-10-27.	@alculquicondor lgtm @ahg-g approve_command @huang-wei lgtm @chendave author @k8s-ci-robot merger	Commit kubernetes/enhancements@1a81f090c5f9c86c34bdf94733247a4b0381e7f7(opens GitHub in a new tab) StatusChange stage ∅ → alpha (2020-09-29)(opens GitHub in a new tab) PullRequest kubernetes/enhancements#2026 Add KEP 1923 - prefer nominated node(opens GitHub in a new tab) Comment kubernetes/enhancements/issues/comments/717504158
2020-10-27 22:17 UTC	status_transition KEP-1923 status set to provisional in PR #2026, approved by ahg-g; merged by automation (k8s-ci-robot) on 2020-10-27.	@alculquicondor lgtm @ahg-g approve_command @huang-wei lgtm @chendave author @k8s-ci-robot merger	Commit kubernetes/enhancements@1a81f090c5f9c86c34bdf94733247a4b0381e7f7(opens GitHub in a new tab) StatusChange status ∅ → provisional (2020-09-29)(opens GitHub in a new tab) PullRequest kubernetes/enhancements#2026 Add KEP 1923 - prefer nominated node(opens GitHub in a new tab) Comment kubernetes/enhancements/issues/comments/717504158
2020-12-23 02:50 UTC	prr_approval wojtek-t gave the production readiness approval for KEP-1923 at alpha on 2020-12-23.	@wojtek-t prr_approver	Document 1923.yaml(opens GitHub in a new tab)
2021-01-11 07:19 UTC	status_transition KEP-1923 status changed from provisional to implementable in PR #2188, approved by ahg-g, wojtek-t; merged by automation (k8s-ci-robot) on 2021-01-11.	@alculquicondor lgtm @ahg-g approve_command @wojtek-t approve_command @wojtek-t lgtm @chendave author @k8s-ci-robot merger	Commit kubernetes/enhancements@1598fc57955147b75584bfc374454ad0733cd386(opens GitHub in a new tab) StatusChange status provisional → implementable (2020-12-16)(opens GitHub in a new tab) PullRequest kubernetes/enhancements#2188 Mark the KEP of "prefer nominated node" as "implementable"
2021-05-21 05:53 UTC	prr_approval wojtek-t gave the production readiness approval for KEP-1923 at beta on 2021-05-21.	@wojtek-t prr_approver	Document 1923.yaml(opens GitHub in a new tab)
2021-06-01 13:56 UTC	milestone_retarget KEP-1923 latest-milestone moved from v1.21 to v1.22 in PR #2764, approved by huang-wei; merged by automation (k8s-ci-robot) on 2021-06-01.	@ahg-g lgtm @huang-wei approve_command @chendave author @k8s-ci-robot merger	Commit kubernetes/enhancements@083b901d1f32f88627ad95064b17094568a87b44(opens GitHub in a new tab) StatusChange latest_milestone v1.21 → v1.22 (2021-05-21)(opens GitHub in a new tab) PullRequest kubernetes/enhancements#2764 Graduate prefer nominated node to beta(opens GitHub in a new tab) Comment kubernetes/enhancements/issues/comments/852145448
2021-06-01 13:56 UTC	stage_graduation KEP-1923 graduated to beta from alpha in PR #2764, approved by huang-wei; merged by automation (k8s-ci-robot) on 2021-06-01.	@ahg-g lgtm @huang-wei approve_command @chendave author @k8s-ci-robot merger	Commit kubernetes/enhancements@083b901d1f32f88627ad95064b17094568a87b44(opens GitHub in a new tab) StatusChange stage alpha → beta (2021-05-21)(opens GitHub in a new tab) PullRequest kubernetes/enhancements#2764 Graduate prefer nominated node to beta(opens GitHub in a new tab) Comment kubernetes/enhancements/issues/comments/852145448
2021-11-23 06:07 UTC	prr_approval wojtek-t gave the production readiness approval for KEP-1923 at stable on 2021-11-23.	@wojtek-t prr_approver	Document 1923.yaml(opens GitHub in a new tab)
2021-12-09 09:28 UTC	milestone_retarget KEP-1923 latest-milestone moved from v1.22 to v1.24 in PR #3057, approved by alculquicondor, wojtek-t; merged by automation (k8s-ci-robot) on 2021-12-09.	@alculquicondor approve_command @alculquicondor lgtm @wojtek-t approve_command @wojtek-t lgtm @chendave author @k8s-ci-robot merger	Commit kubernetes/enhancements@cc12cd71fbaa92cf9bf9cd5f579f7fb314177cc7(opens GitHub in a new tab) StatusChange latest_milestone v1.22 → v1.24 (2021-11-23)(opens GitHub in a new tab) PullRequest kubernetes/enhancements#3057 Graduate `PreferNominatedNode` to GA
2021-12-09 09:28 UTC	stage_graduation KEP-1923 graduated to stable from beta in PR #3057, approved by alculquicondor, wojtek-t; merged by automation (k8s-ci-robot) on 2021-12-09.	@alculquicondor lgtm @alculquicondor approve_command @wojtek-t approve_command @wojtek-t lgtm @chendave author @k8s-ci-robot merger	Commit kubernetes/enhancements@cc12cd71fbaa92cf9bf9cd5f579f7fb314177cc7(opens GitHub in a new tab) StatusChange stage beta → stable (2021-11-23)(opens GitHub in a new tab) PullRequest kubernetes/enhancements#3057 Graduate `PreferNominatedNode` to GA
2022-03-22 06:11 UTC	status_transition KEP-1923 status changed from implementable to implemented in PR #3246, approved by huang-wei; merged by automation (k8s-ci-robot) on 2022-03-22.	@huang-wei approve_command @huang-wei lgtm @chendave author @k8s-ci-robot merger	Commit kubernetes/enhancements@b14a528e9c869feb0b9b39de8fe579daea9677d0(opens GitHub in a new tab) StatusChange status implementable → implemented (2022-03-21)(opens GitHub in a new tab) PullRequest kubernetes/enhancements#3246 KEP-1923: update the status to `implemented`(opens GitHub in a new tab) Comment kubernetes/enhancements/issues/comments/1074776009

Metadata, label and milestone changes, oldest first.Showing 1–10 of 46Rows

Status history
At	Kind	Field	Change	Actor	Evidence
2020-08-06 09:56 UTC	label	needs-sig added	none → needs-sig	@k8s-ci-robot	source(opens GitHub in a new tab)
2020-08-06 09:57 UTC	label	sig/scheduling added	none → sig/scheduling	@k8s-ci-robot	source

Relationships as stored, Person → KEP, from kep.yaml(opens GitHub in a new tab)
Person	Relationship
@chendave GitHub(opens GitHub in a new tab)	—AUTHORED→
@alculquicondor GitHub(opens GitHub in a new tab)	—REVIEWS→
@ahg-g GitHub(opens GitHub in a new tab)	—REVIEWS→
@huang-wei

How they connect

Shortest paths in the graph between this KEP and its SIG or one of its people, up to four hops.

Impact of change

Rows returned by the tool
Kep	Depth	Reached	By hop	Open pull requests	Hop	Feature gates	Sigs	People
{ "label": "KEP", "key": "keps/sig-scheduling/1923-prefer-nominated-node", "title": "Prefer Nominated Node", "url": "https://github.com/kubernetes/enhancements/tree/6ebe0a94771723b3f27cb4a757f0cc22f29e38a2/keps/sig-scheduling/1923-prefer-nominated-node", "evidence_id": "6asqsw3cyky2", "number": 1923, "owning_sig": "sig-scheduling", "status": "implemented", "stage": "stable", "latest_milestone": "v1.24", "milestone_alpha": "v1.21", "milestone_beta": "v1.22", "milestone_stable": "v1.24", "creation_date": "2020-09-29", "metadata_invalid": false }	2	6	{ "1": { "feature_gates": 2, "sigs": 1, "people": 3 } }	not in graph (merged pull requests only)	none	none	none	none
none	none	none	none	none	1	[ { "label": "FeatureGate", "key": "PreferNominatedNode", "title": "PreferNominatedNode", "url": "https://github.com/kubernetes/enhancements/blob/6ebe0a94771723b3f27cb4a757f0cc22f29e38a2/keps/sig-scheduling/1923-prefer-nominated-node/kep.yaml", "evidence_id": "xdedsjbyzmtc", "name": "PreferNominatedNode" }, { "label": "FeatureGate", "key": "TryNominatedNodeFirst", "title": "TryNominatedNodeFirst", "url": "https://github.com/kubernetes/enhancements/blob/1a81f090c5f9c86c34bdf94733247a4b0381e7f7/keps/sig-scheduling/1923-try-nominated-node-first/kep.yaml", "evidence_id": "kfqumj6gzvcf", "name": "TryNominatedNodeFirst" } ]	[ { "label": "SIG", "key": "sig-scheduling", "title": "Scheduling", "url": "https://github.com/kubernetes/community/tree/440e496d3a172234d81728df1bfe43849b589adf/sig-scheduling", "evidence_id": "maif65vfeb5k", "display_name": "Scheduling", "sig_label": "scheduling", "in_scope": true } ]	[ { "label": "Person", "key": "chendave", "title": "chendave", "url": "https://github.com/chendave", "evidence_id": "iqwfnsx7ep37", "login": "chendave", "is_bot": false }, { "label": "Person", "key": "ahg-g", "title": "ahg-g", "url": "https://github.com/ahg-g", "evidence_id": "dkcsjhxbas7w", "login": "ahg-g", "is_bot": false }, { "label": "Person", "key": "huang-wei", "title": "huang-wei", "url": "https://github.com/huang-wei", "evidence_id": "nbxynfywytvd", "login": "huang-wei", "is_bot": false } ]

Rows returned by the tool
Kep	Depth	Reached	By hop	Open pull requests	Hop	Feature gates	Sigs	People
{ "label": "KEP", "key": "keps/sig-scheduling/1923-prefer-nominated-node", "title": "Prefer Nominated Node", "url": "https://github.com/kubernetes/enhancements/tree/6ebe0a94771723b3f27cb4a757f0cc22f29e38a2/keps/sig-scheduling/1923-prefer-nominated-node", "evidence_id": "6asqsw3cyky2", "number": 1923, "owning_sig": "sig-scheduling", "status": "implemented", "stage": "stable", "latest_milestone": "v1.24", "milestone_alpha": "v1.21", "milestone_beta": "v1.22", "milestone_stable": "v1.24", "creation_date": "2020-09-29", "metadata_invalid": false }	2	6	{ "1": { "feature_gates": 2, "sigs": 1, "people": 3 } }	not in graph (merged pull requests only)	none	none	none	none
none	none	none	none	none	1	[ { "label": "FeatureGate", "key": "PreferNominatedNode", "title": "PreferNominatedNode", "url": "https://github.com/kubernetes/enhancements/blob/6ebe0a94771723b3f27cb4a757f0cc22f29e38a2/keps/sig-scheduling/1923-prefer-nominated-node/kep.yaml", "evidence_id": "xdedsjbyzmtc", "name": "PreferNominatedNode" }, { "label": "FeatureGate", "key": "TryNominatedNodeFirst", "title": "TryNominatedNodeFirst", "url": "https://github.com/kubernetes/enhancements/blob/1a81f090c5f9c86c34bdf94733247a4b0381e7f7/keps/sig-scheduling/1923-try-nominated-node-first/kep.yaml", "evidence_id": "kfqumj6gzvcf", "name": "TryNominatedNodeFirst" } ]	[ { "label": "SIG", "key": "sig-scheduling", "title": "Scheduling", "url": "https://github.com/kubernetes/community/tree/440e496d3a172234d81728df1bfe43849b589adf/sig-scheduling", "evidence_id": "maif65vfeb5k", "display_name": "Scheduling", "sig_label": "scheduling", "in_scope": true } ]	[ { "label": "Person", "key": "chendave", "title": "chendave", "url": "https://github.com/chendave", "evidence_id": "iqwfnsx7ep37", "login": "chendave", "is_bot": false }, { "label": "Person", "key": "ahg-g", "title": "ahg-g", "url": "https://github.com/ahg-g", "evidence_id": "dkcsjhxbas7w", "login": "ahg-g", "is_bot": false }, { "label": "Person", "key": "huang-wei", "title": "huang-wei", "url": "https://github.com/huang-wei", "evidence_id": "nbxynfywytvd", "login": "huang-wei", "is_bot": false } ]

Kep

Depth

Reached

By hop

Open pull requests

Hop

Feature gates

Sigs

People

{
  "label": "KEP",
  "key": "keps/sig-scheduling/1923-prefer-nominated-node",
  "title": "Prefer Nominated Node",
  "url": "https://github.com/kubernetes/enhancements/tree/6ebe0a94771723b3f27cb4a757f0cc22f29e38a2/keps/sig-scheduling/1923-prefer-nominated-node",
  "evidence_id": "6asqsw3cyky2",
  "number": 1923,
  "owning_sig": "sig-scheduling",
  "status": "implemented",
  "stage": "stable",
  "latest_milestone": "v1.24",
  "milestone_alpha": "v1.21",
  "milestone_beta": "v1.22",
  "milestone_stable": "v1.24",
  "creation_date": "2020-09-29",
  "metadata_invalid": false
}

{
  "1": {
    "feature_gates": 2,
    "sigs": 1,
    "people": 3
  }
}

not in graph (merged pull requests only)

[
  {
    "label": "FeatureGate",
    "key": "PreferNominatedNode",
    "title": "PreferNominatedNode",
    "url": "https://github.com/kubernetes/enhancements/blob/6ebe0a94771723b3f27cb4a757f0cc22f29e38a2/keps/sig-scheduling/1923-prefer-nominated-node/kep.yaml",
    "evidence_id": "xdedsjbyzmtc",
    "name": "PreferNominatedNode"
  },
  {
    "label": "FeatureGate",
    "key": "TryNominatedNodeFirst",
    "title": "TryNominatedNodeFirst",
    "url": "https://github.com/kubernetes/enhancements/blob/1a81f090c5f9c86c34bdf94733247a4b0381e7f7/keps/sig-scheduling/1923-try-nominated-node-first/kep.yaml",
    "evidence_id": "kfqumj6gzvcf",
    "name": "TryNominatedNodeFirst"
  }
]

[
  {
    "label": "SIG",
    "key": "sig-scheduling",
    "title": "Scheduling",
    "url": "https://github.com/kubernetes/community/tree/440e496d3a172234d81728df1bfe43849b589adf/sig-scheduling",
    "evidence_id": "maif65vfeb5k",
    "display_name": "Scheduling",
    "sig_label": "scheduling",
    "in_scope": true
  }
]

[
  {
    "label": "Person",
    "key": "chendave",
    "title": "chendave",
    "url": "https://github.com/chendave",
    "evidence_id": "iqwfnsx7ep37",
    "login": "chendave",
    "is_bot": false
  },
  {
    "label": "Person",
    "key": "ahg-g",
    "title": "ahg-g",
    "url": "https://github.com/ahg-g",
    "evidence_id": "dkcsjhxbas7w",
    "login": "ahg-g",
    "is_bot": false
  },
  {
    "label": "Person",
    "key": "huang-wei",
    "title": "huang-wei",
    "url": "https://github.com/huang-wei",
    "evidence_id": "nbxynfywytvd",
    "login": "huang-wei",
    "is_bot": false
  }
]

MATCH (k:KEP {key: $key}) RETURN k LIMIT 1 ; MATCH (k:KEP {key: $key}) MATCH path = (k)-[:REPLACES|SUPERSEDED_BY|SEE_ALSO|GATED_BY*1..2]-(n) WHERE n <> k AND (n:KEP OR n:FeatureGate) AND all(x IN nodes(path)[1..-1] WHERE x <> k AND (x:KEP OR (x:FeatureGate AND NOT x.key IN $placeholders))) WITH n, path ORDER BY length(path), [x IN nodes(path) | x.key] WITH n, collect(path)[0] AS path RETURN n AS node, length(path) AS hop, path ORDER BY hop, n.key LIMIT 150 ; UNWIND $keys AS kk MATCH (k:KEP {key: kk}) RETURN k.key AS kep, [(k)-[r_0:OWNED_BY]->(s_0:SIG) WHERE coalesce(r_0.valid_to, $open) = $open | s_0] AS sigs, [(p_1:Person)-[r_1:AUTHORED]->(k) WHERE coalesce(r_1.valid_to, $open) = $open AND coalesce(p_1.is_bot, false) = false | p_1] AS authors, [(p_2:Person)-[r_2:APPROVES]->(k) WHERE coalesce(r_2.valid_to, $open) = $open AND coalesce(p_2.is_bot, false) = false | p_2] AS approvers, [(k)-[r_3:TRACKED_BY]->(i_3:Issue) WHERE coalesce(r_3.valid_to, $open) = $open AND i_3.state = 'open' | i_3] AS open_issues LIMIT 200

Prefer Nominated Node

Facts

How they connect

Impact of change

Keyboard shortcuts

Everywhere

Go to a page

Ask

Search lists

KEP page

Findings table

How they connect

Impact of change

Hop 1

Impact of change

Impact of change

Hop 1